Re: [PATCH v4 03/14] of: Make of_property_present() applicable to all kinds of property

[Zijun Hu]

On 2025/1/11 01:45, Rob Herring wrote:
> On Thu, Jan 09, 2025 at 09:26:54PM +0800, Zijun Hu wrote:
>> From: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
>>
>> API of_property_present() invokes of_property_read_bool() to check if
>> a property is present or not, and that has 2 shortcomings shown below:
>>
>> - That narrows down property scope applicable to of_property_present()
>>   from all kinds of property to only bool type.
>>
>> - That is less logical since it says a property's presence is decided by
>>   its bool property value.
>>
>> Fix by making of_property_read_bool() invoke of_property_present().
> 
> I already indicated I wasn't interested in taking this until we have 
> reason to split the behavior. I've sent out a series on that now[1].
> 

the patch you indicate is patch [4/14] as below, not this patch [3/14]
https://lore.kernel.org/all/CAL_JsqJvh5pddoVEgaKQvGth0ncgtC9AAGxMEiK__NiZKrjmxA@xxxxxxxxxxxxxx/

the actual change of this patch is only to swap function name between
of_property_present() and of_property_read_bool() even if it seems this
patch has many changed lines.

okay, let me drop this patch in v5. (^^)

> Rob
> 
> [1] https://lore.kernel.org/all/20250109-dt-type-warnings-v1-0-0150e32e716c@xxxxxxxxxx/