Re: [PATCH 1/2] Revert "gpio: 74x164: Add On Semi MC74HC595A compat"

[Krzysztof Kozlowski]

On Fri, Jan 10, 2025 at 02:00:24PM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> This reverts commit b1468db9d865deb5271c9a20d05201b1c0636895.
> 
> There's no need to add a new compatible to the driver code, we can
> handle it with a DT fallback.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> ---

I assume this was not released anywhere, judging by dates, but would be
nice to see confirmation in commit msg or changelog.

>  drivers/gpio/gpio-74x164.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index 2ce00e90ea56..fca6cd2eb1dd 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -165,7 +165,6 @@ static void gen_74x164_remove(struct spi_device *spi)
>  
>  static const struct spi_device_id gen_74x164_spi_ids[] = {
>  	{ .name = "74hc595" },
> -	{ .name = "74hc595a" },

Hm, strictly speaking this is not related. What if some
spi-driver-matching uses 74hc595a? There is no compatibility for
such matches.

Best regards,
Krzysztof