Re: [PATCH] spmi: Fix controller->node != parent->node breakage
From: kernel test robot
Date: Sat Jan 11 2025 - 22:48:51 EST
Hi Konrad,
kernel test robot noticed the following build errors:
[auto build test ERROR on 2b88851f583d3c4e40bcd40cfe1965241ec229dd]
url: https://github.com/intel-lab-lkp/linux/commits/Konrad-Dybcio/spmi-Fix-controller-node-parent-node-breakage/20250111-192215
base: 2b88851f583d3c4e40bcd40cfe1965241ec229dd
patch link: https://lore.kernel.org/r/20250111-topic-spmi_node_breakage-v1-1-3f60111a1d19%40oss.qualcomm.com
patch subject: [PATCH] spmi: Fix controller->node != parent->node breakage
config: hexagon-randconfig-002-20250112 (https://download.01.org/0day-ci/archive/20250112/202501121127.soBkTzgY-lkp@xxxxxxxxx/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project f5cd181ffbb7cb61d582fe130d46580d5969d47a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250112/202501121127.soBkTzgY-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501121127.soBkTzgY-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/spmi/hisi-spmi-controller.c:272:8: error: expected ')'
272 | sizeof(*spmi_controller));
| ^
drivers/spmi/hisi-spmi-controller.c:270:35: note: to match this '('
270 | ctrl = devm_spmi_controller_alloc(&pdev->dev,
| ^
1 error generated.
vim +272 drivers/spmi/hisi-spmi-controller.c
262
263 static int spmi_controller_probe(struct platform_device *pdev)
264 {
265 struct spmi_controller_dev *spmi_controller;
266 struct spmi_controller *ctrl;
267 struct resource *iores;
268 int ret;
269
270 ctrl = devm_spmi_controller_alloc(&pdev->dev,
271 pdev->dev.of_node
> 272 sizeof(*spmi_controller));
273 if (IS_ERR(ctrl)) {
274 dev_err(&pdev->dev, "can not allocate spmi_controller data\n");
275 return PTR_ERR(ctrl);
276 }
277 spmi_controller = spmi_controller_get_drvdata(ctrl);
278 spmi_controller->controller = ctrl;
279
280 iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
281 if (!iores) {
282 dev_err(&pdev->dev, "can not get resource!\n");
283 return -EINVAL;
284 }
285
286 spmi_controller->base = devm_ioremap(&pdev->dev, iores->start,
287 resource_size(iores));
288 if (!spmi_controller->base) {
289 dev_err(&pdev->dev, "can not remap base addr!\n");
290 return -EADDRNOTAVAIL;
291 }
292
293 ret = of_property_read_u32(pdev->dev.of_node, "hisilicon,spmi-channel",
294 &spmi_controller->channel);
295 if (ret) {
296 dev_err(&pdev->dev, "can not get channel\n");
297 return -ENODEV;
298 }
299
300 platform_set_drvdata(pdev, spmi_controller);
301 dev_set_drvdata(&ctrl->dev, spmi_controller);
302
303 spin_lock_init(&spmi_controller->lock);
304
305 ctrl->dev.parent = pdev->dev.parent;
306
307 /* Callbacks */
308 ctrl->read_cmd = spmi_read_cmd;
309 ctrl->write_cmd = spmi_write_cmd;
310
311 ret = devm_spmi_controller_add(&pdev->dev, ctrl);
312 if (ret) {
313 dev_err(&pdev->dev, "spmi_controller_add failed with error %d!\n", ret);
314 return ret;
315 }
316
317 return 0;
318 }
319
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki