Re: [PATCH v9 2/4] iio: accel: adxl345: initialize FIFO delay value for SPI
From: Andy Shevchenko
Date: Sun Jan 12 2025 - 10:57:36 EST
Sat, Dec 28, 2024 at 11:29:47PM +0000, Lothar Rubusch kirjoitti:
> Add the possibility to delay FIFO access when SPI is used. According to
> the datasheet this is needed for the adxl345. When initialization
> happens over SPI the need for delay is to be signalized, and the delay
> will be used.
...
> int adxl345_core_probe(struct device *dev, struct regmap *regmap,
> + bool fifo_delay_default,
> int (*setup)(struct device*, struct regmap*));
Missing spaces, but it seems the original issue.
...
> int adxl345_core_probe(struct device *dev, struct regmap *regmap,
> + bool fifo_delay_default,
> int (*setup)(struct device*, struct regmap*))
Ditto.
...
> #define ADXL345_MAX_SPI_FREQ_HZ 5000000
> +#define ADXL345_MAX_FREQ_NO_FIFO_DELAY 1500000
In which units? Usually we add a unit suffix, e.g., _US (for microseconds).
--
With Best Regards,
Andy Shevchenko