Re: [PATCH v4 1/5] iio: adc: ad7380: do not use iio_device_claim_direct_scoped anymore
From: Andy Shevchenko
Date: Sun Jan 12 2025 - 15:20:09 EST
On Sun, Jan 12, 2025 at 6:42 PM Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
>
> On Sun, 12 Jan 2025 18:29:42 +0200
> Andy Shevchenko <andy.shevchenko@xxxxxxxxx> wrote:
>
> > Wed, Jan 08, 2025 at 01:49:33PM +0100, Julien Stephan kirjoitti:
> > > Conditionnal scoped handlers are turning out to be a real pain:
> > > readability issues, compiler and linker handling issues among others so
> > > rollback and remove the scoped version of iio_dvice_claim_direct_mode.
> >
> > Is it IIO level decision or you as a contributor to/maintainer of this driver?
> > If the former? can you add a Link to the discussion?
>
>
> IIO. Agreed a link would have been sensible here.
>
> >
> > Otherwise, I would like to understand the common approach / practices in IIO
> > WRT individual drivers to deviate the common approaches. Jonathan?
>
> Patch series on list ripping the whole lot out that has some more explanation
> and links. Basically we never found a way to overcome the short comings of
> conditional scoped guards.
>
> https://lore.kernel.org/linux-iio/20250105172613.1204781-1-jic23@xxxxxxxxxx/
Thanks, it was an interesting dive into "how did I spend my holidays?" essay.
--
With Best Regards,
Andy Shevchenko