Re: [PATCH 06/12] dt-bindings: clk: sunxi-ng: add V853 CCU clock/reset

[András Szemző]

Thanks for your comments for the whole series!
Not everything is clear for me yet, but I’ll clarify with sunxi community, and
fix it based on your suggestions.

> On 11 Jan 2025, at 11:34, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
> 
> On Fri, Jan 10, 2025 at 01:39:17PM +0100, Andras Szemzo wrote:
>> As the device tree needs the clock/reset indices, add them to DT binding
>> headers.
>> 
>> Signed-off-by: Andras Szemzo <szemzo.andras@xxxxxxxxx>
>> ---
>> include/dt-bindings/clock/sun8i-v853-ccu.h   | 132 +++++++++++++++++++
> 
> Please use full compatible as filename.
> 
>> include/dt-bindings/clock/sun8i-v853-r-ccu.h |  16 +++
>> include/dt-bindings/reset/sun8i-v853-ccu.h   |  62 +++++++++
>> include/dt-bindings/reset/sun8i-v853-r-ccu.h |  14 ++
>> 4 files changed, 224 insertions(+)
>> create mode 100644 include/dt-bindings/clock/sun8i-v853-ccu.h
>> create mode 100644 include/dt-bindings/clock/sun8i-v853-r-ccu.h
>> create mode 100644 include/dt-bindings/reset/sun8i-v853-ccu.h
>> create mode 100644 include/dt-bindings/reset/sun8i-v853-r-ccu.h
>> 
>> diff --git a/include/dt-bindings/clock/sun8i-v853-ccu.h b/include/dt-bindings/clock/sun8i-v853-ccu.h
>> new file mode 100644
>> index 000000000000..a405b982f914
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/sun8i-v853-ccu.h
>> @@ -0,0 +1,132 @@
>> +/* SPDX-License-Identifier: (GPL-2.0+ OR MIT) */
> 
> BTW, also checkpatch warns about this...
> 
> Best regards,
> Krzysztof
>