Re: [PATCH 5/5] remoteproc: st: Use syscon_regmap_lookup_by_phandle_args

[Patrice CHOTARD]

On 1/11/25 19:42, Krzysztof Kozlowski wrote:
> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over
> syscon_regmap_lookup_by_phandle() and getting the argument.  Except
> simpler code this annotates within one line that given phandle has
> arguments, so grepping for code would be easier.
> 
> There is also no real benefit in printing errors on missing syscon
> argument, because this is done just too late: runtime check on
> static/build-time data.  Dtschema and Devicetree bindings offer the
> static/build-time check for this already.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  drivers/remoteproc/st_remoteproc.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c
> index d1f35e8a83ba525613ed4e54d2269b7e9f427e46..e6566a9839dc5ffc83d907a3076fc4b0a644138a 100644
> --- a/drivers/remoteproc/st_remoteproc.c
> +++ b/drivers/remoteproc/st_remoteproc.c
> @@ -314,18 +314,12 @@ static int st_rproc_parse_dt(struct platform_device *pdev)
>  		return err;
>  	}
>  
> -	ddata->boot_base = syscon_regmap_lookup_by_phandle(np, "st,syscfg");
> +	ddata->boot_base = syscon_regmap_lookup_by_phandle_args(np, "st,syscfg",
> +								1, &ddata->boot_offset);
>  	if (IS_ERR(ddata->boot_base))
>  		return dev_err_probe(dev, PTR_ERR(ddata->boot_base),
>  				     "Boot base not found\n");
>  
> -	err = of_property_read_u32_index(np, "st,syscfg", 1,
> -					 &ddata->boot_offset);
> -	if (err) {
> -		dev_err(dev, "Boot offset not found\n");
> -		return -EINVAL;
> -	}
> -
>  	err = clk_prepare(ddata->clk);
>  	if (err)
>  		dev_err(dev, "failed to get clock\n");
> 

Reviewed-by: Patrice Chotard <patrice.chotard@xxxxxxxxxxx>

Thanks
Patrice