Re: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Ignore SUBSYS_ID not found for tas2563 projects

[Xu, Baojun]

_> _______________________________________
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Sent: 13 January 2025 16:37
> To: Xu, Baojun
> Cc: tiwai@xxxxxxx; robh+dt@xxxxxxxxxx; lgirdwood@xxxxxxxxx; perex@xxxxxxxx; Ding, Shenghao; Navada Kanyana, Mukund; 13916275206@xxxxxxx; Hampiholi, Vallabha; P O, Vijeth; linux-sound@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; liam.r.girdwood@xxxxxxxxx; yung-chuan.liao@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxx; antheas.dk@xxxxxxxxx; stuart.a.hayhurst@xxxxxxxxx
> Subject: [EXTERNAL] Re: [PATCH v1] ALSA: hda/tas2781: Ignore SUBSYS_ID not found for tas2563 projects
> 
> On Mon, Dec 30, 2024 at 02: 49: 10PM +0800, Baojun Xu wrote: > Driver will return error if no SUBSYS_ID found in BIOS(acpi). > It will cause error in tas2563 projects, which have no SUBSYS_ID. .. . > + /* No subsys id in older tas2563
> ZjQcmQRYFpfptBannerStart
> This message was sent from outside of Texas Instruments.
> Do not click links or open attachments unless you recognize the source of this email and know the content is safe.
> <https://us-phishalarm-ewt.proofpoint.com/EWT/v1/G3vK!uBdnXZsDVuK1AUis0BxokFYl0U8msKJqQQTam8jBr5s6Aqzw9WEAd5LLFN0eVy0N20B_F7wSVDAFGD70$>
> Report Suspicious
> 
> ZjQcmQRYFpfptBannerEnd
> 
> On Mon, Dec 30, 2024 at 02:49:10PM +0800, Baojun Xu wrote:
> > Driver will return error if no SUBSYS_ID found in BIOS(acpi).
> > It will cause error in tas2563 projects, which have no SUBSYS_ID.
> 
> ...
> 
> > +             /* No subsys id in older tas2563 projects. */
> > +             if (!strncmp(hid, "INT8866", sizeof("INT8866")))
> > +                     goto end_2563;
> 
> Is this ID was used on old platforms?

Yes. And it will never be used in our product again.

> 
> --
> With Best Regards,
> Andy Shevchenko
> 
>