Re: [PATCH v4 4/4] arm64: dts: s32g399a-rdb3: Add INA231 sensor entry over I2C4

[Ciprian Marian Costea]

On 12/20/2024 5:55 PM, Frank Li wrote:
> On Fri, Dec 20, 2024 at 02:39:16PM +0200, Ciprian Costea wrote:
> > From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx>
> >
> > On S32G399A-RDB3 boards, an INA231 current sensor is connected over
> > I2C4 bus.
>
> Add INA231 current sensor for S32G399A-RDB3 boards.
>
> > Signed-off-by: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts | 8 ++++++++
> >   1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts b/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
> > index 94f531be4017..5f8739c068c6 100644
> > --- a/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
> > +++ b/arch/arm64/boot/dts/freescale/s32g399a-rdb3.dts
> > @@ -40,6 +40,14 @@ &uart1 {
> >   	status = "okay";
> >   };
> >
> > +&i2c4 {
> > +	ina231@40 {
>
> Need use general node name:
> https://devicetree-specification.readthedocs.io/en/v0.3/devicetree-basics.html#node-names
>
> look like should be current-sensor
>
> Frank

Thanks. I will update in V5.

Ciprian

> > +		compatible = "ti,ina231";
> > +		reg = <0x40>;
> > +		shunt-resistor = <1000>;
> > +	};
> > +};
> > +
> >   &usdhc0 {
> >   	pinctrl-names = "default", "state_100mhz", "state_200mhz";
> >   	pinctrl-0 = <&pinctrl_usdhc0>;
> > --
> > 2.45.2