Re: [PATCH] HID: lenovo: Fix undefined platform_profile_cycle in ThinkPad X12 keyboard patch

[Vishnu Sankar]

Jiri,
Thanks a lot.

On Sat, Jan 11, 2025 at 12:05 AM Jiri Kosina <jikos@xxxxxxxxxx> wrote:
>
> On Fri, 10 Jan 2025, Vishnu Sankar wrote:
>
> > The commit "HID: lenovo: Support for ThinkPad-X12-TAB-1/2 Kbd Fn keys"
> > introduced an issue where the CI failed with the following error:
> > ERROR: modpost: "platform_profile_cycle" [drivers/hid/hid-lenovo.ko] undefined!
> >
> > This issue occurs because platform_profile_cycle is used without ensuring
> > the kernel is configured with CONFIG_ACPI_PLATFORM_PROFILE.
> > To address this, this patch adds conditional support for platform profile
> > management to the Fn+F8 key handling.
> > The functionality for platform_profile_cycle is now included only when
> > CONFIG_ACPI_PLATFORM_PROFILE is enabled in the kernel configuration.
> >
> > This ensures compatibility with kernels that do not include the ACPI
> > platform profile feature, resolving the CI build issue.
>
> Applied, thanks.
>
> --
> Jiri Kosina
> SUSE Labs
>


-- 

Regards,

      Vishnu Sankar
     +817015150407 (Japan)