Re: [PATCH 1/3] docs: submitting-patches: clarify Acked-by and introduce "# Suffix"

From: Krzysztof Kozlowski
Date: Mon Jan 13 2025 - 06:52:19 EST


On 12/01/2025 16:29, Miguel Ojeda wrote:
> Acked-by is typically used by maintainers. However, sometimes it is
> useful to be able to accept the tag from other stakeholders that may not
> have done a deep technical review or may not be kernel developers. For
> instance:
>
> - People with domain knowledge, such as the original author of the
> code being modified.
>
> - Userspace-side reviewers for a kernel uAPI patch, like in DRM --
> see Documentation/gpu/drm-uapi.rst:
>
> > The userspace-side reviewer should also provide an Acked-by on the
> > kernel uAPI patch indicating that they believe the proposed uAPI
> > is sound and sufficiently documented and validated for userspace's
> > consumption.
>
> - Key users of a feature, such as in [1].
>
> Thus clarify that Acked-by may be used by other stakeholders (but most
> commonly by maintainers).
>
> Since, in these cases, it may be confusing why an Acked-by is/was
> provided, allow and suggest to provide a "# Suffix" explaining it.
>
> The "# Suffix" for Acked-by is already being used to clarify what part
> of the patch a maintainer is acknowledging, thus also mention "# Suffix"
> in the relevant paragraph.
>
> Link: https://lore.kernel.org/rust-for-linux/CANiq72m4fea15Z0fFZauz8N2madkBJ0G7Dc094OwoajnXmROOA@xxxxxxxxxxxxxx/ [1]
> Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> Acked-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> ---
> Documentation/process/submitting-patches.rst | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)

Acked-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
Best regards,
Krzysztof