Re: [PATCH v4 27/30] fs: Add iput() cleanup helper

[Jann Horn]

On Wed, Jan 8, 2025 at 4:44 PM Mickaël Salaün <mic@xxxxxxxxxxx> wrote:
> Add a simple scope-based helper to put an inode reference, similar to
> the fput() helper.

Cleaning up inode references with scope-based cleanup seems dangerous
to me because, unlike most resources, holding a reference to an inode
beyond the lifetime of the associated superblock can actually cause
memory corruption; and scope-based cleanup is designed based on the
idea that the order and precise location of dropping a reference don't
matter so much.

So I would prefer to either not do this, or at least have some big
warning comment about usage requirements of scope-based inode
references.