Re: [PATCH v9 2/7] tools: arm64: Update sysreg.h header files

From: Marc Zyngier
Date: Mon Jan 13 2025 - 10:29:22 EST


On Mon, 13 Jan 2025 15:07:21 +0000,
Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> [1 <text/plain; us-ascii (quoted-printable)>]
> On Mon, Jan 06, 2025 at 02:24:37PM +0000, James Clark wrote:
> > From: James Clark <james.clark@xxxxxxx>
> >
> > Created with the following:
> >
> > cp include/linux/kasan-tags.h tools/include/linux/
> > cp arch/arm64/include/asm/sysreg.h tools/arch/arm64/include/asm/
> >
> > Update the tools copy of sysreg.h so that the next commit to add a new
> > register doesn't have unrelated changes in it. Because the new version
> > of sysreg.h includes kasan-tags.h, that file also now needs to be copied
> > into tools.
>
> This breaks the build of the KVM selftests:
>
> aarch64/aarch32_id_regs.c:150:16: error: use of undeclared identifier 'ID_AA64PFR0_EL1_ELx_64BIT_ONLY'
> 150 | return el0 == ID_AA64PFR0_EL1_ELx_64BIT_ONLY;
> | ^
> 1 warning and 1 error generated.
>
> since it's pulled over the changes in 056600ff7330 ("arm64/cpufeature:
> Replace custom macros with fields from ID_AA64PFR0_EL1") but not updated
> the test to reflect this.

Thanks for the heads up. I've stashed a fix on top, which hopefully
will be in next tomorrow.

M.

--
Without deviation from the norm, progress is not possible.