Re: [PATCH] drm/panel-edp: Add B140UAN04.4 and MNE007QS3-7

[Doug Anderson]

Hi,

On Mon, Jan 13, 2025 at 1:42 AM Langyan Ye
<yelangyan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote:
>
>
>
> ---------- Forwarded message ---------
> From: Langyan Ye <yelangyan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, Dec 25, 2024 at 10:01 AM
> Subject: [PATCH] drm/panel-edp: Add B140UAN04.4 and MNE007QS3-7
> To: <dianders@xxxxxxxxxxxx>, <neil.armstrong@xxxxxxxxxx>, <quic_jesszhan@xxxxxxxxxxx>, <maarten.lankhorst@xxxxxxxxxxxxxxx>, <mripard@xxxxxxxxxx>, <tzimmermann@xxxxxxx>, <airlied@xxxxxxxxx>, <simona@xxxxxxxx>, <dri-devel@xxxxxxxxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: <dianders@xxxxxxxxxx>, Langyan Ye <yelangyan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
>
>
> The raw edid for B140UAN04.4 panel is:
>
> 00 ff ff ff ff ff ff 00 06 af b3 a7 00 00 00 00
> 0c 22 01 04 a5 1e 13 78 03 cb 55 91 57 5a 91 29
> 1c 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 f4 3c 80 b8 70 b0 24 40 10 10
> 3e 00 2d bc 10 00 00 18 00 00 00 0f 00 00 00 00
> 00 00 00 00 00 00 00 00 00 20 00 00 00 fe 00 41
> 55 4f 0a 20 20 20 20 20 20 20 20 20 00 00 00 fe
> 00 42 31 34 30 55 41 4e 30 34 2e 34 20 0a 01 46
>
> 70 20 79 02 00 22 00 14 87 61 02 85 7f 07 b7 00
> 0f 80 0f 00 af 04 23 00 02 00 0d 00 25 01 09 87
> 61 02 87 61 02 28 3c 80 81 00 15 74 1a 00 00 03
> 01 28 3c 00 00 53 50 53 50 3c 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0b 90
>
> The raw edid for MNE007QS3-7 panel is:
>
> 00 ff ff ff ff ff ff 00 0e 77 48 14 00 00 00 00
> 34 20 01 04 a5 1e 13 78 03 2c c5 94 5c 59 95 29
> 1e 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01
> 01 01 01 01 01 01 ea 3d 80 c8 70 b0 2e 40 30 20
> 36 00 2e bd 10 00 00 1a 00 00 00 fd 00 28 3c 4b
> 4b 10 01 0a 20 20 20 20 20 20 00 00 00 fe 00 43
> 53 4f 54 20 54 39 0a 20 20 20 20 20 00 00 00 fe
> 00 4d 4e 45 30 30 37 51 53 33 2d 37 0a 20 00 df
>
> Signed-off-by: Langyan Ye <yelangyan@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
> index f8511fe5fb0d..e9434a0cc37a 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -1865,6 +1865,7 @@ static const struct edp_panel_entry edp_panels[] = {
>         EDP_PANEL_ENTRY('A', 'U', 'O', 0xc4b4, &delay_200_500_e50, "B116XAT04.1"),
>         EDP_PANEL_ENTRY('A', 'U', 'O', 0xd497, &delay_200_500_e50, "B120XAN01.0"),
>         EDP_PANEL_ENTRY('A', 'U', 'O', 0xf390, &delay_200_500_e50, "B140XTN07.7"),
> +       EDP_PANEL_ENTRY('A', 'U', 'O', 0xa7b3, &delay_200_500_e50, "B140UAN04.4"),

This is mis-sorted. 0xa7b3 doesn't come after 0xf390. I'll fix it up
while applying so no need to resend, but this is extra work for me.
Please make sure IDs are sorted next time.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Pushed to drm-misc-next:

[1/1] drm/panel-edp: Add B140UAN04.4 and MNE007QS3-7
      commit: 0ca6d6058852857c628b479f1e7aad3386036bdb