Re: [PATCH v5] hwmon: (pwm-fan): Default to the Maximum cooling level if provided

From: Guenter Roeck
Date: Mon Jan 13 2025 - 11:56:45 EST


On Mon, Jan 13, 2025 at 02:51:18PM +0100, Peter Korsgaard wrote:
> The pwm-fan driver uses full PWM (255) duty cycle at startup, which may not
> always be desirable because of noise or power consumption peaks.
>
> The driver optionally accept a list of "cooling-levels" for the thermal
> subsystem. If provided, use the PWM value corresponding to the maximum
> cooling level rather than the full level as the initial PWM setting.
>
> Signed-off-by: Peter Korsgaard <peter@xxxxxxxxxxxxx>

Applied, after

> + ret = pwm_fan_get_cooling_data(dev, ctx);
> + if (ret)
> + return ret;
> +
> +

dropping this double empty line.

Guenter