Re: [PATCH v2 3/3] padata: avoid UAF for reorder_work

From: Daniel Jordan
Date: Mon Jan 13 2025 - 12:00:49 EST


On Fri, Jan 10, 2025 at 06:16:39AM +0000, Chen Ridong wrote:
...
> Fixes: bbefa1dd6a6d ("crypto: pcrypt - Avoid deadlock by using per-instance padata queues")
> Signed-off-by: Chen Ridong <chenridong@xxxxxxxxxx>

Series looks good, thanks for the persistence.

Acked-by: Daniel Jordan <daniel.m.jordan@xxxxxxxxxx>

> diff --git a/kernel/padata.c b/kernel/padata.c
...
> static void invoke_padata_reorder(struct work_struct *work)
> @@ -364,6 +370,8 @@ static void invoke_padata_reorder(struct work_struct *work)
> pd = container_of(work, struct parallel_data, reorder_work);
> padata_reorder(pd);
> local_bh_enable();
> + /* Pairs with putting the reorder_work in the serial_wq */

s/putting/getting/