Re: [PATCH V2] security: fix typos and spelling errors

[Mimi Zohar]

On Mon, 2025-01-13 at 15:50 +0100, Günther Noack wrote:
> On Sun, Jan 12, 2025 at 12:59:27PM +0530, Tanya Agarwal wrote:
> > From: Tanya Agarwal <tanyaagarwal25699@xxxxxxxxx>
> > 
> > Fix typos and spelling errors in security module comments that were
> > identified using the codespell tool.
> > No functional changes - documentation only.
> > 
> > Signed-off-by: Tanya Agarwal <tanyaagarwal25699@xxxxxxxxx>
> > ---
> > Thanks Günther, for catching this error.
> > The irony of having a spelling mistake in a patch that fixes spelling
> > mistakes is not lost on me :) 
> > 
> > I've fixed it in V2 of the patch. Thank you for the careful review!
> > 
> > V2: fix spelling mistake - s/beeen/been/ 
> > 
> >  security/apparmor/apparmorfs.c      | 6 +++---
> >  security/apparmor/domain.c          | 4 ++--
> >  security/apparmor/label.c           | 2 +-
> >  security/apparmor/lsm.c             | 2 +-
> >  security/apparmor/policy.c          | 4 ++--
> >  security/integrity/evm/evm_crypto.c | 2 +-
> >  security/integrity/evm/evm_main.c   | 2 +-
> >  security/integrity/ima/ima_main.c   | 6 +++---
> >  security/landlock/ruleset.c         | 2 +-
> >  security/selinux/avc.c              | 2 +-
> >  security/smack/smack.h              | 2 +-
> >  security/smack/smack_access.c       | 4 ++--
> >  security/smack/smack_lsm.c          | 6 +++---
> >  security/smack/smackfs.c            | 2 +-
> >  security/tomoyo/domain.c            | 2 +-
> >  15 files changed, 24 insertions(+), 24 deletions(-)
> > 
> 
> [...]
> 
> > diff --git a/security/integrity/ima/ima_main.c
> > b/security/integrity/ima/ima_main.c
> > index 9b87556b03a7..cdb8c7419d7e 100644
> > --- a/security/integrity/ima/ima_main.c
> > +++ b/security/integrity/ima/ima_main.c
> > @@ -983,9 +983,9 @@ int process_buffer_measurement(struct mnt_idmap *idmap,
> >  	}
> >  
> >  	/*
> > -	 * Both LSM hooks and auxilary based buffer measurements are
> > -	 * based on policy.  To avoid code duplication, differentiate
> > -	 * between the LSM hooks and auxilary buffer measurements,
> > +	 * Both LSM hooks and auxiliary based buffer measurements are
> > +	 * based on policy. To avoid code duplication, differentiate
>                           ^^^
> 
> (Small nit:) This change from two-spaces-after-the-dot to a single
> space looks like it happened accidentally.  The two-space style is
> dominant in the ima_main.c file.
> 
> (However, I am not involved in IMA and others have more authority to
> review this part.  As Paul also said, reviews tend to go smoother when
> the scope for the patch is a single subsystem - it makes the
> responsibilities clearer.)
> 
> > +	 * between the LSM hooks and auxiliary buffer measurements,

The spelling mistake being corrected in two places is auxilary -> auxiliary.  Thank
you for noticing the unnecessary change from two spaces to one space as well.

FYI, I agree with Paul the patch should be split.

Reviewed-by: Mimi Zohar <zohar@xxxxxxxxxxxxx>


> >  	 * retrieving the policy rule information only for the LSM hook
> >  	 * buffer measurements.
> >  	 */
> 
> –Günther