Re: [PATCH] select: Fix unbalanced user_access_end()
From: Al Viro
Date: Mon Jan 13 2025 - 14:48:00 EST
On Mon, Jan 13, 2025 at 09:37:24AM +0100, Christophe Leroy wrote:
> While working on implementing user access validation on powerpc
> I got the following warnings on a pmac32_defconfig build:
>
> CC fs/select.o
> fs/select.o: warning: objtool: sys_pselect6+0x1bc: redundant UACCESS disable
> fs/select.o: warning: objtool: sys_pselect6_time32+0x1bc: redundant UACCESS disable
>
> On powerpc/32s, user_read_access_begin/end() are no-ops, but the
> failure path has a user_access_end() instead of user_read_access_end()
> which means an access end without any prior access begin.
>
> Replace that user_access_end() by user_read_access_end().
ACK.