Re: [PATCH v3 05/10] ARM: dts: aspeed: system1: Add RGMII support

From: Ninad Palsule
Date: Mon Jan 13 2025 - 14:53:54 EST


Hi Andrew,

On 1/8/25 11:03, Andrew Lunn wrote:
On Wed, Jan 08, 2025 at 10:36:33AM -0600, Ninad Palsule wrote:
system1 has 2 transceiver connected through the RGMII interfaces. Added
device tree entry to enable RGMII support.

ASPEED AST2600 documentation recommends using 'rgmii-rxid' as a
'phy-mode' for mac0 and mac1 to enable the RX interface delay from the
PHY chip.
You appear to if ignored my comment. Please don't do that. If you have
no idea about RGMII delays, please say so, so i can help you debug
what is wrong.

NACK

Andrew

Thanks for the review. I have dropped this patch from version 4 until Jacky fixes the driver.

Regards,

Ninad