Re: [PATCH v2] Input: i8042 - Add support for platform filter contexts

[Dmitry Torokhov]

On Fri, Jan 10, 2025 at 04:38:56PM +0200, Ilpo Järvinen wrote:
> On Thu, 2 Jan 2025, Armin Wolf wrote:
> 
> > Am 22.12.24 um 22:50 schrieb Armin Wolf:
> > 
> > > Currently the platform filter cannot access any driver-specific state
> > > which forces drivers installing a i8042 filter to have at least some
> > > kind of global pointer for their filter.
> > > 
> > > This however might cause issues should such a driver probe multiple
> > > devices. Fix this by allowing callers of i8042_install_filter() to
> > > submit a context pointer which is then passed to the i8042 filter.
> > > 
> > > Also introduce a separate type for the i8042 filter (i8042_filter_t)
> > > so that the function definitions can stay compact.
> > > 
> > > Tested on a Dell Inspiron 3505.
> > 
> > Any updates on this?
> 
> We haven't heard what Dimitry thinks of the reasonale you gave in v1.
> 
> I'd like to have this as it allows us clean up the globals on pdx86 side 
> even if i8042 is still limited to a single filter (and uses globals 
> itself).

OK, this is better justification IMO, because I do not believe we
actually have an instance where we do not know who owns and should
activate the filter on a given device.

Please update the commit description to that effect and merge it.

Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

Thanks.

-- 
Dmitry