Re: [PATCH v2 2/3] arm64: dts: qcom: qcs9100: Update memory map

[Dmitry Baryshkov]

On Mon, Jan 13, 2025 at 06:08:26PM +0530, Pratyush Brahma wrote:
> 
> On 1/13/2025 5:50 PM, Krzysztof Kozlowski wrote:
> > On 13/01/2025 13:13, Pratyush Brahma wrote:
> > > Update the iot specific memory map for qcs9100* boards.
> > Why?
> > 
> > Every single time. Don't say what, we see it easily. Say why.
> I assumed incorrectly it would be perhaps enough to have mentioned
> this in patch 1 of this series and the cover letter, so didn't mention here.

You wrote it in the patch 1, so it covered SA8775P-Ride boards. This
patch concerns QCS9100 boards. So it is a completely separate topic.

> Can you please review the memory map changes in patch 1 as well?
> Once the strategy for the dts changes are baked in internally with the

Please. Please. s/internally/externally/. Start discussing things on the
MLs rather than baking the solution internally and then being surprised
when the bakery isn't being accepted by the community.

> current reviews, I will send out another series incorporating the comments
> with the memory map changes.
> > > Signed-off-by: Pratyush Brahma <quic_pbrahma@xxxxxxxxxxx>
> > > ---
> > >   arch/arm64/boot/dts/qcom/qcs9100-ride-r3.dts | 2 ++
> > >   arch/arm64/boot/dts/qcom/qcs9100-ride.dts    | 2 ++
> > >   2 files changed, 4 insertions(+)
> > > 
> > Best regards,
> > Krzysztof
> 
> -- 
> Thanks and Regards
> Pratyush Brahma
> 

-- 
With best wishes
Dmitry