Re: [PATCH v5 2/4] dt-bindings: clock: drop NUM_CLOCKS define for EN7581

From: Stephen Boyd
Date: Mon Jan 13 2025 - 16:33:45 EST


Subject says EN7581....

Quoting Christian Marangi (2025-01-12 05:39:38)
> Drop NUM_CLOCKS define for EN7581 include. This is not a binding and
> should not be placed here. Value is derived internally in the user
> driver.
>
> Signed-off-by: Christian Marangi <ansuelsmth@xxxxxxxxx>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> Changes v5:
> - Add ack tag
> Changes v4:
> - Move to patch 2 (improves bisectability)
> Changes v3:
> - Add this patch
>
> include/dt-bindings/clock/en7523-clk.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/dt-bindings/clock/en7523-clk.h b/include/dt-bindings/clock/en7523-clk.h
> index 717d23a5e5ae..28e56745ccff 100644
> --- a/include/dt-bindings/clock/en7523-clk.h
> +++ b/include/dt-bindings/clock/en7523-clk.h
> @@ -12,6 +12,4 @@
> #define EN7523_CLK_CRYPTO 6
> #define EN7523_CLK_PCIE 7
>
> -#define EN7523_NUM_CLOCKS 8

But this is EN7523

drivers/clk/clk-en7523.c:539:25: error: ‘EN7523_NUM_CLOCKS’ undeclared (first use in this function)
539 | clk_data->num = EN7523_NUM_CLOCKS;
| ^~~~~~~~~~~~~~~~~