RE: [Intel-wired-lan] [iwl-next PATCH v4 1/3] idpf: Acquire the lock before accessing the xn->salt

From: Singh, Krishneil K
Date: Tue Jan 14 2025 - 01:59:15 EST



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of
> Brian Vazquez
> Sent: Monday, December 16, 2024 8:28 AM
> To: Brian Vazquez <brianvv.kernel@xxxxxxxxx>; Nguyen, Anthony L
> <anthony.l.nguyen@xxxxxxxxx>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@xxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>;
> Eric Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>;
> Paolo Abeni <pabeni@xxxxxxxxxx>; intel-wired-lan@xxxxxxxxxxxxxxxx
> Cc: David Decotigny <decot@xxxxxxxxxx>; Vivek Kumar
> <vivekmr@xxxxxxxxxx>; Singhai, Anjali <anjali.singhai@xxxxxxxxx>;
> Samudrala, Sridhar <sridhar.samudrala@xxxxxxxxx>; linux-
> kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Tantilov, Emil S
> <emil.s.tantilov@xxxxxxxxx>; Manoj Vishwanathan
> <manojvishy@xxxxxxxxxx>; Brian Vazquez <brianvv@xxxxxxxxxx>; Keller,
> Jacob E <jacob.e.keller@xxxxxxxxx>; Linga, Pavan Kumar
> <pavan.kumar.linga@xxxxxxxxx>
> Subject: [Intel-wired-lan] [iwl-next PATCH v4 1/3] idpf: Acquire the lock before
> accessing the xn->salt
>
> From: Manoj Vishwanathan <manojvishy@xxxxxxxxxx>
>
> The transaction salt was being accessed before acquiring the
> idpf_vc_xn_lock when idpf has to forward the virtchnl reply.
>
> Fixes: 34c21fa894a1 ("idpf: implement virtchnl transaction manager")
> Signed-off-by: Manoj Vishwanathan <manojvishy@xxxxxxxxxx>
> Signed-off-by: David Decotigny <decot@xxxxxxxxxx>
> Signed-off-by: Brian Vazquez <brianvv@xxxxxxxxxx>
> Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
> Reviewed-by: Pavan Kumar Linga <pavan.kumar.linga@xxxxxxxxx>
> ---
> drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Tested-by: Krishneil Singh <krishneil.k.singh@xxxxxxxxx>