[PATCH] selftests/timens/procfs: Fix Resource leak proc in read_proc_uptime

From: liuye
Date: Tue Jan 14 2025 - 03:15:20 EST


Exception branch returns without closing proc.
Signed-off-by: liuye <liuye@xxxxxxxxxx>
---
tools/testing/selftests/timens/procfs.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/tools/testing/selftests/timens/procfs.c b/tools/testing/selftests/timens/procfs.c
index 1833ca97eb24..e47844a73c31 100644
--- a/tools/testing/selftests/timens/procfs.c
+++ b/tools/testing/selftests/timens/procfs.c
@@ -79,9 +79,11 @@ static int read_proc_uptime(struct timespec *uptime)
if (fscanf(proc, "%lu.%02lu", &up_sec, &up_nsec) != 2) {
if (errno) {
pr_perror("fscanf");
+ fclose(proc);
return -errno;
}
pr_err("failed to parse /proc/uptime");
+ fclose(proc);
return -1;
}
fclose(proc);
--
2.25.1