Re: [PATCH net-next 2/3] eth: fbnic: hwmon: Add support for reading temperature and voltage sensors

[Michal Swiatkowski]

On Mon, Jan 13, 2025 at 04:07:04PM -0800, Sanman Pradhan wrote:
> Add support for reading temperature and voltage sensor data from firmware
> by implementing a new TSENE message type and response parsing. This adds
> message handler infrastructure to transmit sensor read requests and parse
> responses. The sensor data will be exposed through the driver's hwmon interface.
> 
> Signed-off-by: Sanman Pradhan <sanman.p211993@xxxxxxxxx>
> ---
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.c  | 89 ++++++++++++++++++++-
>  drivers/net/ethernet/meta/fbnic/fbnic_fw.h  | 15 ++++
>  drivers/net/ethernet/meta/fbnic/fbnic_mac.c | 72 +++++++++++++++++
>  drivers/net/ethernet/meta/fbnic/fbnic_mac.h |  7 ++
>  4 files changed, 179 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> index 320615a122e4..bbc7c1c0c37e 100644
> --- a/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> +++ b/drivers/net/ethernet/meta/fbnic/fbnic_fw.c
> @@ -228,9 +228,9 @@ static void fbnic_mbx_process_tx_msgs(struct fbnic_dev *fbd)
>  	tx_mbx->head = head;
>  }
> 

[...]

Reviewed-by: Michal Swiatkowski <michal.swiatkowski@xxxxxxxxxxxxxxx>

> --
> 2.43.5