Re: [PATCH v2 1/4] dt-bindings: clock: convert stm32 rcc bindings to json-schema

[Krzysztof Kozlowski]

On 14/01/2025 10:10, Dario Binacchi wrote:
> On Sat, Jan 11, 2025 at 10:25 AM Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On Thu, Jan 09, 2025 at 10:18:28PM +0100, Dario Binacchi wrote:
>>> +maintainers:
>>> +  - Dario Binacchi <dario.binacchi@xxxxxxxxxxxxxxxxxxxx>
>>> +
>>> +description: |
>>> +  The RCC IP is both a reset and a clock controller.
>>> +  The reset phandle argument is the bit number within the RCC registers bank,
>>> +  starting from RCC base address.
>>> +
>>> +properties:
>>> +  compatible:
>>> +    oneOf:
>>> +      - items:
>>> +          - const: st,stm32f42xx-rcc
>>> +          - const: st,stm32-rcc
>>> +      - items:
>>> +          - enum:
>>> +              - st,stm32f469-rcc
>>> +          - const: st,stm32f42xx-rcc
>>> +          - const: st,stm32-rcc
>>> +      - items:
>>> +          - const: st,stm32f746-rcc
>>
>> Why this isn't just part of enum with first group/list? Different
>> groups/lists are for different fallbacks and I am pretty sure fallback
>> is the same.
> 
> I tried running tests after applying the changes you suggested, but
> the tests are failing.
And? Fix the code then?

Best regards,
Krzysztof