Re: [PATCH v2 09/18] riscv: vdso: Switch to generic storage implementation

[Conor Dooley]

On Tue, Jan 14, 2025 at 09:40:11AM +0100, Thomas Weißschuh wrote:
> On Mon, Jan 13, 2025 at 07:48:15PM +0000, Conor Dooley wrote:
> > On Fri, Jan 10, 2025 at 04:23:48PM +0100, Thomas Weißschuh wrote:
> > > The generic storage implementation provides the same features as the
> > > custom one. However it can be shared between architectures, making
> > > maintenance easier.
> > > 
> > > Co-developed-by: Nam Cao <namcao@xxxxxxxxxxxxx>
> > > Signed-off-by: Nam Cao <namcao@xxxxxxxxxxxxx>
> > > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@xxxxxxxxxxxxx>
> > 
> > For rv64, nommu:
> >   LD      vmlinux
> > ld.lld: error: undefined symbol: vmf_insert_pfn
> > >>> referenced by datastore.c
> > >>>               lib/vdso/datastore.o:(vvar_fault) in archive vmlinux.a
> > 
> > ld.lld: error: undefined symbol: _install_special_mapping
> > >>> referenced by datastore.c
> > >>>               lib/vdso/datastore.o:(vdso_install_vvar_mapping) in archive vmlinux.a
> > 
> > Later patches in the series don't make it build again.
> > rv32 builds now though, so thanks for fixing that.
> 
> Thanks for the report.
> Can you try to diff below?

Ye, that resolved it. Thanks!

Attachment: signature.asc
Description: PGP signature