Re: [PATCH v7 05/12] drm/bridge: cdns-dsi: Fix the clock variable for mode_valid()

[Dmitry Baryshkov]

On Tue, Jan 14, 2025 at 11:26:19AM +0530, Aradhya Bhatia wrote:
> From: Aradhya Bhatia <a-bhatia1@xxxxxx>
> 
> The crtc_* mode parameters do not get generated (duplicated in this
> case) from the regular parameters before the mode validation phase
> begins.
> 
> The rest of the code conditionally uses the crtc_* parameters only
> during the bridge enable phase, but sticks to the regular parameters
> for mode validation. In this singular instance, however, the driver
> tries to use the crtc_clock parameter even during the mode validation,
> causing the validation to fail.
> 
> Allow the D-Phy config checks to use mode->clock instead of
> mode->crtc_clock during mode_valid checks, like everywhere else in the
> driver.
> 
> Fixes: fced5a364dee ("drm/bridge: cdns: Convert to phy framework")
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@xxxxxx>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@xxxxxxxxx>
> ---
>  drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
-- 
With best wishes
Dmitry