Re: [net-next PATCH v3 2/6] octeontx2-pf: Add AF_XDP non-zero copy support

From: Paolo Abeni
Date: Tue Jan 14 2025 - 07:39:46 EST


On 1/10/25 10:38 AM, Suman Ghosh wrote:
> For XDP, page_pool APIs are getting used now. But the memory type was
> not getting set due to which XDP_REDIRECT and hence AF_XDP was not
> working. This patch ads the memory type MEM_TYPE_PAGE_POOL as the memory
> model of the XDP program.
>
> Signed-off-by: Suman Ghosh <sumang@xxxxxxxxxxx>

This looks like a fixes that deserve its own fix tag and likely going
trough the 'net' tree.

I think you can still include in a net-next series to simplify the
merging, but the fix tag should be added anyway.

> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> index 2859f397f99e..730f2b7742db 100644
> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_txrx.c
> @@ -96,7 +96,7 @@ static unsigned int frag_num(unsigned int i)
>
> static void otx2_xdp_snd_pkt_handler(struct otx2_nic *pfvf,
> struct otx2_snd_queue *sq,
> - struct nix_cqe_tx_s *cqe)
> + struct nix_cqe_tx_s *cqe)
> {
> struct nix_send_comp_s *snd_comp = &cqe->comp;
> struct sg_list *sg;

For the same reasons, please move the white-space changes to a later patch.

Thanks,

Paolo