Re: [PATCH v1 1/3] drm/admgpu: replace kmalloc() and memcpy() with kmemdup()
From: Alex Deucher
Date: Tue Jan 14 2025 - 09:28:19 EST
On Tue, Jan 14, 2025 at 5:37 AM Carlos Maiolino <cem@xxxxxxxxxx> wrote:
>
> On Tue, 17 Dec 2024 23:58:10 +0100, Mirsad Todorovac wrote:
> > The static analyser tool gave the following advice:
> >
> > ./drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c:1266:7-14: WARNING opportunity for kmemdup
> >
> > → 1266 tmp = kmalloc(used_size, GFP_KERNEL);
> > 1267 if (!tmp)
> > 1268 return -ENOMEM;
> > 1269
> > → 1270 memcpy(tmp, &host_telemetry->body.error_count, used_size);
> >
> > [...]
>
> Applied to for-next, thanks!
FWIW, I already picked up the amdgpu patch for drm-next on Dec 18th.
Alex
>
> [1/3] drm/admgpu: replace kmalloc() and memcpy() with kmemdup()
> (no commit info)
> [2/3] xfs/libxfs: replace kmalloc() and memcpy() with kmemdup()
> commit: 9d9b72472631262b35157f1a650f066c0e11c2bb
> [3/3] btrfs: replace kmalloc() and memcpy() with kmemdup()
> (no commit info)
>
> Best regards,
> --
> Carlos Maiolino <cem@xxxxxxxxxx>
>