[PATCH 3/3] x86/mce: Make mce_notify_irq() depend on CONFIG_X86_MCELOG_LEGACY
From: Nikolay Borisov
Date: Tue Jan 14 2025 - 11:38:07 EST
mce_notify_irq() really depends on the legacy mcelog being enabled as
otherwise mce_work_trigger() will never schedule the trigger work as
mce_helper can't be set unless CONFIG_X86_MCELOG_LEGACY is defined.
Signed-off-by: Nikolay Borisov <nik.borisov@xxxxxxxx>
---
In addition to making the body of this function depend on MCELOG, mce_need_notify
also depends entirely on MCELOG, however I haven't added it since I don't want to
proliferate ifdefs, this begs the qustion whether this patch is acceptable ?
arch/x86/kernel/cpu/mce/core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/mce/core.c b/arch/x86/kernel/cpu/mce/core.c
index 2544e9ae7449..4e2f6c162b43 100644
--- a/arch/x86/kernel/cpu/mce/core.c
+++ b/arch/x86/kernel/cpu/mce/core.c
@@ -591,6 +591,7 @@ EXPORT_SYMBOL_GPL(mce_is_correctable);
*/
static int mce_notify_irq(void)
{
+#ifdef CONFIG_X86_MCELOG_LEGACY
/* Not more than two messages every minute */
static DEFINE_RATELIMIT_STATE(ratelimit, 60*HZ, 2);
@@ -602,7 +603,7 @@ static int mce_notify_irq(void)
return 1;
}
-
+#endif
return 0;
}
--
2.43.0