Re: [PATCH net-next v1 1/3] net: stmmac: Switch to zero-copy in non-XDP RX path

From: Alexander Lobakin
Date: Tue Jan 14 2025 - 12:24:18 EST


From: Andrew Lunn <andrew@xxxxxxx>
Date: Mon, 13 Jan 2025 17:48:22 +0100

>> 1. It's author's responsibility to read netdev CI output on Patchwork,
>> reviewers shouldn't copy its logs.
>
> I somewhat disagree with that. We want the author to of already run
> all the static analysers before they post code. We don't want the
> mailing list abused as a CI system.

Sure. Maybe I wasn't clear enough, but I don't encourage using our
MLs/CIs to test stuff :D What I meant is that reviewers shouldn't copy
stuff from the Patchwork output. The authors themselves should track
their series there, but only to make sure everything is fine, not to
"let's see if I need to fix anything else".

>
> So rather than pointing out a specific problem, it can be better to
> say that static analysers XZY is not happy with this patch, please run
> it and fix the issues it reports.

Right, probably the best way.

>
> Andrew

Thanks,
Olek