Re: [PATCH] APEI: GHES: Have GHES honor the panic= setting

[Rafael J. Wysocki]

On Mon, Jan 13, 2025 at 9:08 PM Ira Weiny <ira.weiny@xxxxxxxxx> wrote:
>
> Borislav Petkov wrote:
> > The GHES driver overrides the panic= setting by force-rebooting the
> > system after a fatal hw error has been reported. The intent being that
> > such an error would be reported earlier.
> >
> > However, this is not optimal when a hard-to-debug issue requires long
> > time to reproduce and when that happens, the box will get rebooted after
> > 30 seconds and thus destroy the whole hw context of when the error
> > happened.
> >
> > So rip out the default GHES panic timeout and honor the global one.
> >
> > In the panic disabled (panic=0) case, the error will still be logged to
> > dmesg for later inspection and if panic after a hw error is really
> > required, then that can be controlled the usual way - use panic= on the
> > cmdline or set it in the kernel .config's CONFIG_PANIC_TIMEOUT.
> >
> > Reported-by: Feng Tang <feng.tang@xxxxxxxxxxxxxxxxx>
> > Signed-off-by: Borislav Petkov (AMD) <bp@xxxxxxxxx>
> > Reviewed-by: Feng Tang <feng.tang@xxxxxxxxxxxxxxxxx>
>
> Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx>

Applied as 6.14 material, thanks!