Re: [PATCH bpf v5 1/3] bpf: fix wrong copied_seq calculation

[Jakub Kicinski]

On Tue, 14 Jan 2025 14:35:34 +0800 Jiayuan Chen wrote:
> > To state the obvious feels like the abstraction between TCP and psock
> > has broken down pretty severely at this stage. You're modifying TCP
> > and straight up calling TCP functions from skmsg.c :(
> >  
> You are right!
> 
> How about we construct code like this:
> 
> sk_psock_strp_read_sock(strp)    skmsg.c
>     tcp_bpf_strp_read_sock(sk)   tcp_bpf.c
>         tcp_read_sock_noack(sk)  tcp.c
> 
> In skmsg.c we just register read_sock handler for strparser, then move
> core code into tcp_bpf.c. I believe it makes more sense than before as
> there already exist some psock with tcp operation(especially ops handler)
> implemented in tcp_bpf.c.

Yes, that's slightly better, thanks