Re: [PATCH v10 04/10] arm64/sysreg: Add a comment that the sysreg file should be sorted

From: Mark Brown
Date: Tue Jan 14 2025 - 14:45:38 EST


On Tue, Jan 14, 2025 at 12:16:27PM -0600, Rob Herring wrote:
> On Mon, Jan 13, 2025 at 10:49 AM Marc Zyngier <maz@xxxxxxxxxx> wrote:

> > The better option would be to add the comment *and* sort the file.
> > Leading by example has some value, it seems.

> IME, it's better if documentation just states what the tools enforce.

> Can't we add something like this to the header generation:

> $ grep '^Sysreg\s' arch/arm64/tools/sysreg | sort -n -k3 -k4 -k5 -k6 -k7 -c
> sort: -:22: disorder: Sysreg ID_MMFR4_EL1 3 0 0
> 2 6

Sounds good to me.

Attachment: signature.asc
Description: PGP signature