Re: [PATCH next] squashfs: Fix a NULL vs IS_ERR() bug

From: Phillip Lougher
Date: Tue Jan 14 2025 - 16:25:47 EST




On 1/8/25 09:16, Dan Carpenter wrote:
The __filemap_get_folio() functoin never returns NULL, it returns
error pointers. This incorrect check would lead to an Oops on the
following line when we pass "push_folio" to folio_test_uptodate().

Fixes: 43c73ba98b2c ("squashfs; convert squashfs_copy_cache() to take a folio")
Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Reviewed-by: Phillip Lougher <phillip@xxxxxxxxxxxxxxx>