Re: [PATCH v3] net: dsa: mv88e6xxx: propperly shutdown PPU re-enable timer on destroy

[Jakub Kicinski]

On Mon, 13 Jan 2025 09:49:12 +0100 David Oberhollenzer wrote:
> @@ -7323,6 +7323,8 @@ static int mv88e6xxx_probe(struct mdio_device *mdiodev)
>  		mv88e6xxx_g1_irq_free(chip);
>  	else
>  		mv88e6xxx_irq_poll_free(chip);
> +out_phy:
> +	mv88e6xxx_phy_destroy(chip);
>  out:
>  	if (pdata)
>  		dev_put(pdata->netdev);

If this is the right ordering the order in mv88e6xxx_remove()
looks suspicious. We call mv88e6xxx_phy_destroy() pretty early 
and then unregister from DSA. Isn't there a window where DSA 
callbacks can reschedule the timer?
-- 
pw-bot: cr