RE: [PATCH v7 07/15] scsi: fnic: Add and integrate support for FDMI

[Karan Tilak Kumar (kartilak)]

On Tuesday, January 14, 2025 7:15 AM, John Meneghini <jmeneghi@xxxxxxxxxx> wrote:
>
> Hi Dan.
>
> I absolutely agree with all of your comments and I appreciate your review.
> I agree that all of the issues you've pointed out, with the the exception of
> one, need to be addressed. The issues pointed out - especially the string
> manipulation issues - can turn into CVEs. We don't want to be checking bugs
> like this into Linux. Certainly, nothing should be merged that does not
> pass the static checker, et al, automated tools we have.
>
> My comment here was only to say that I don't think it's reasonable to
> ask Karan to break this change into a series of 100 small, reviewable changes.
>
> To explain: the fnic driver is Cisco's driver. Cisco has always taken responsibility
> for this driver and Karan is one of the many Cisco Maintainers. What's happening is,
> after a long period of time where the code has been somewhat neglected, Cisco has
> decided to do a major update of their upstream driver. These changes
> are really more like a new driver, with some major new features, than a
> series of bug fixes or updates. This is happening because - at the insistence
> of some of the Distros, like Red Hat - Cisco is being told they need to bring
> their upstream drivers in line with their out-of-box drivers.
>
> Karan can confirm if this is the case. My question for Karan is: are there any more
> major driver changes coming for fnic, or is this the majority of it?
>

This current set of changes is the biggest set.
We have a few more small features planned for the future, not for 6.14.
They are quite limited in their scope.

Regards,
Karan