Re: [PATCH] kasan: hw_tags: Use str_on_off() helper in kasan_init_hw_tags()

[Andrey Konovalov]

On Tue, Jan 14, 2025 at 4:10 PM Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
>
> Remove hard-coded strings by using the str_on_off() helper function.
>
> Suggested-by: Anshuman Khandual <anshuman.khandual@xxxxxxx>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>
> ---
>  mm/kasan/hw_tags.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/hw_tags.c b/mm/kasan/hw_tags.c
> index ccd66c7a4081..9a6927394b54 100644
> --- a/mm/kasan/hw_tags.c
> +++ b/mm/kasan/hw_tags.c
> @@ -16,6 +16,7 @@
>  #include <linux/mm.h>
>  #include <linux/static_key.h>
>  #include <linux/string.h>
> +#include <linux/string_choices.h>
>  #include <linux/types.h>
>  #include <linux/vmalloc.h>
>
> @@ -263,8 +264,8 @@ void __init kasan_init_hw_tags(void)
>
>         pr_info("KernelAddressSanitizer initialized (hw-tags, mode=%s, vmalloc=%s, stacktrace=%s)\n",
>                 kasan_mode_info(),
> -               kasan_vmalloc_enabled() ? "on" : "off",
> -               kasan_stack_collection_enabled() ? "on" : "off");
> +               str_on_off(kasan_vmalloc_enabled()),
> +               str_on_off(kasan_stack_collection_enabled()));
>  }
>
>  #ifdef CONFIG_KASAN_VMALLOC
> --
> 2.47.1
>

Reviewed-by: Andrey Konovalov <andreyknvl@xxxxxxxxx>

Thanks!