Re: [PATCH v7 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

[Chukun Pan]

Hi,
> [1] https://github.com/photonicat/rockchip_rk3568_kernel/blob/novotech-5.10/arch/arm64/boot/dts/rockchip/rk3568-photonicat-base.dtsi

I don't think this link has reference value. I was misled
by this several times when I wrote dts before.

> +&pcie3x2 {
> +	max-link-speed = <1>;
> +	num-lanes = <1>;

I'm not sure about this.
This PCIe3.0 x2 is not split.

> +&sdmmc1 {
> ...
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>;

pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_clk &sdmmc1_cmd>;

> +	wifi: wifi@1 {
> +		reg = <1>;

No aliases needed.
Other parts LGTM.

-- 
2.25.1