Re: [PATCH 06/14] cpumask: re-introduce cpumask_next{,_and}_wrap()
From: Yury Norov
Date: Tue Jan 14 2025 - 22:41:23 EST
On Fri, Jan 03, 2025 at 11:44:32AM -0600, Bjorn Helgaas wrote:
> On Sat, Dec 28, 2024 at 10:49:38AM -0800, Yury Norov wrote:
> > cpumask_next_wrap_old() has two additional parameters, comparing to it's
> > analogue in linux/find.h find_next_bit_wrap(). The reason for that is
> > historical.
>
> s/it's/its/
>
> Personally I think cscope/tags/git grep make "find_next_bit_wrap()"
> enough even without mentioning "linux/find.h".
>
> > + * cpumask_next_and_wrap - get the next cpu in *src1p & *src2p, starting from
> > + * @n and wrapping around, if needed
> > + * @n: the cpu prior to the place to search (i.e. return will be > @n)
>
> Is the return really > @n if it wraps?
No, this is a copy-paste error. Will fix in v2.
Thanks,
Yury