Re: [PATCH v1 1/2] landlock: Handle weird files

From: Christoph Hellwig
Date: Wed Jan 15 2025 - 02:16:40 EST


On Sat, Jan 11, 2025 at 04:38:56PM +0100, Mickaël Salaün wrote:
> I guess it depends on the filesystem implementation. For instance, XFS
> returns an error if a weird file is detected [1], whereas bcachefs
> ignores it (which is considered a bug, but not fixed yet) [2].

If a filesyste, returns an invalid mode that's a file system bug and
needs to be fixed there. Warning in a consumer is perfectly fine.
But the right action in that case is indeed not to grant the access.