Re: [PATCH next] firmware: qcom: scm: Fix error code in probe()

From: Krzysztof Kozlowski
Date: Wed Jan 15 2025 - 03:20:58 EST

Next message: Petr Mladek: "[PATCH v1 00/19] livepatch: Better integrate callbacks and shadow variables with the states API"
Previous message: Krzysztof Kozlowski: "[PATCH] clk: nomadik: Correct str_enabled_disabled() SXTALO case"
In reply to: Dan Carpenter: "[PATCH next] firmware: qcom: scm: Fix error code in probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 15/01/2025 07:52, Dan Carpenter wrote:
> Set the error code if devm_qcom_tzmem_pool_new() fails. Don't return
> success.
>
> Fixes: 1e76b546e6fc ("firmware: qcom: scm: Cleanup global '__scm' on probe failures")
> Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

Uh, one can stare at own code for hours and never see the issue.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof

Next message: Petr Mladek: "[PATCH v1 00/19] livepatch: Better integrate callbacks and shadow variables with the states API"
Previous message: Krzysztof Kozlowski: "[PATCH] clk: nomadik: Correct str_enabled_disabled() SXTALO case"
In reply to: Dan Carpenter: "[PATCH next] firmware: qcom: scm: Fix error code in probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]