Re: [PATCH 4/4] arm64: dts: renesas: Add initial device tree for Yuridenki-Shokai Kakip board

From: Krzysztof Kozlowski
Date: Wed Jan 15 2025 - 03:37:04 EST


On 14/01/2025 14:44, Geert Uytterhoeven wrote:
>>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml?h=v6.11-rc1#n46
>>
>>> + compatible = "regulator-fixed";
>>> +
>>> + regulator-name = "fixed-3.3V";
>>> + regulator-min-microvolt = <3300000>;
>>> + regulator-max-microvolt = <3300000>;
>>> + regulator-boot-on;
>>> + regulator-always-on;
>>> + };
>>> +
>>> + vqmmc_sdhi0: regulator-vccq-sdhi0 {
>>
>> regulator-2? Why different styles of names?
>
> ... i.e. no numbered regulators, as these tend to cause hard-to-debug
> conflicts.
"regulator-vccq-sdhi0" also works for me, because the recommended
pattern might have name conflicts, but then please keep the style across
all of them in this patch.

Best regards,
Krzysztof