Re: [PATCH v3 1/2] dt-bindings: hwmon: ti,ina2xx: Add INA233 device

[Krzysztof Kozlowski]

On Wed, Jan 15, 2025 at 09:55:20AM +0800, Leo Yang wrote:
> @@ -75,12 +76,40 @@ properties:
>        the alert polarity to active-high.
>      $ref: /schemas/types.yaml#/definitions/flag
>  
> +  ti,current-lsb-microamp:
> +    description: |
> +      This value depends on the maximum current that can be expected to be
> +      measured by ina233 in your circuit, divide Maximum Expected Current
> +      by 2^15 and express it in microamps.

No, express here maximum expected current. Otherwise what is here?
Define the physical property, not the value used by your driver.

> +
> +      This value will be used to calculate the current/power coefficient for
> +      the pmbus and to calibrate the IC.
> +    minimum: 0x1

s/0x1/1/

maximum?
default?

> +
>  required:
>    - compatible
>    - reg

Best regards,
Krzysztof