Re: [PATCH net-next v7 3/3] net: stmmac: dwmac-nuvoton: Add dwmac glue for Nuvoton MA35 family

[Joey Lu]

Dear Paul,

Thank you for your kind reply.

Paul Menzel 於 1/15/2025 5:22 PM 寫道:
> Dear Joey,
>
>
> Thank you for your prompt reply.
>
>
> Am 15.01.25 um 10:03 schrieb Joey Lu:
>
> > Paul Menzel 於 1/14/2025 9:49 AM 寫道:
>
> […]
>
> > > Am 13.01.25 um 00:54 schrieb Joey Lu:
> > > > Add support for Gigabit Ethernet on Nuvoton MA35 series using dwmac 
> > > > driver.
>
> […]
>
> > > Also, please document how tested the driver. Maybe even paste new 
> > > log messages.
> >
> > These are the kernel configurations for testing the MA35D1 GMAC 
> > driver: ARCH_MA35, STMMAC_PLATFORM, DWMAC_NUVOTON.
> >
> > I'm not sure if this information is sufficient, so please provide 
> > some guidance on what else I should include to meet your requirements.
>
> I’d be interested on what hardware you tested it. Probably some 
> evaluation or customer reference board.
The driver has been validated on our development boards, 
NuMaker-IoT-MA35D1-A1 and NuMaker-HMI-MA35D1-S1.
> > I will include the log messages at the end of the email.
>
> Awesome. Thank you. Personally, I also like to see those in the commit 
> message.
Understood. I will include in the commit message in the next patch.
> > > > Reviewed-by: Andrew Lunn <andrew@xxxxxxx>
> > > > Signed-off-by: Joey Lu <a0987203069@xxxxxxxxx>
> > >
> > > As you use your company email address in the AUTHOR line below, 
> > > please also add that email address to the commit message (and maybe 
> > > even as the author).
> >
> > I will update the AUTHOR to use my personal email address instead of 
> > the company email.
>
> Understood. (yclu4@xxxxxxxxxxx is also personal, but the Gmail address 
> is private, I guess. ;-)).
Oops, I meant to say "private" instead.
> For statistics, how companies contribute to the Linux kernel, having 
> the company address somewhere would be nice though, as you are doing 
> this as your work at Nuvoton, right?
I will keep the company information in the driver header as you mentioned.
> > > > ---
> > > >   drivers/net/ethernet/stmicro/stmmac/Kconfig   |  11 ++
> > > >   drivers/net/ethernet/stmicro/stmmac/Makefile  |   1 +
> > > >   .../ethernet/stmicro/stmmac/dwmac-nuvoton.c   | 179 
> > > > ++++++++++++++++++
> > > >   3 files changed, 191 insertions(+)
> > > >   create mode 100644 
> > > > drivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c
>
> […]
>
> > log:
> >
> > [    T0] Booting Linux on physical CPU 0x0000000000 [0x411fd040]
>
> Out of curiosity, how do you get these timestamps T0, T1, …?
>
> […]
>
>
> Thank you and kind regards,
>
> Paul

I simply forgot to enable CONFIG_PRINTK_TIME. Here is what the log looks 
like after enabling it.

[    1.886100] nuvoton-dwmac 40120000.ethernet: TX Checksum insertion 
supported
[    1.893104] nuvoton-dwmac 40120000.ethernet: Enhanced/Alternate 
descriptors
[    1.900048] nuvoton-dwmac 40120000.ethernet: Enabled extended descriptors
[    1.906806] nuvoton-dwmac 40120000.ethernet: Ring mode enabled
[    1.912611] nuvoton-dwmac 40120000.ethernet: Enable RX Mitigation via 
HW Watchdog Timer

BR,

Joey