Re: [PATCH v3] ALSA: hda: Support for Ideapad hotkey mute LEDs

[Takashi Iwai]

On Wed, 15 Jan 2025 16:48:11 +0100,
Jackie Dong wrote:
> 
> 
> New ideapad helper file with support for handling FN key mute LEDs.
> Update conexant and realtec codec to add LED support.
> 
> Suggested-by: Mark Pearson <mpearson-lenovo@xxxxxxxxx>
> Signed-off-by: Jackie Dong  <xy-jackie@xxxxxxx>

It's almost fine, just one minor thing:

> @@ -11130,6 +11146,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>  	{.id = ALC290_FIXUP_MONO_SPEAKERS_HSJACK, .name = "mono-speakers"},
>  	{.id = ALC290_FIXUP_SUBWOOFER_HSJACK, .name = "alc290-subwoofer"},
>  	{.id = ALC269_FIXUP_THINKPAD_ACPI, .name = "thinkpad"},
> +	{.id = ALC269_FIXUP_LENOVO_XPAD_ACPI, .name = "lenovo xpad led"},

The model string shouldn't contain a space.  It'd be too difficult to
specify in the boot option.  Use a hyphen instead.


thanks,

Takashi