Re: [PATCH linux-next v1] PCI: rockchip: Improve error handling in clock return value

From: Anand Moon
Date: Wed Jan 15 2025 - 13:23:04 EST


Hi Mani/ Bjon,

On Wed, 15 Jan 2025 at 23:18, Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>
> On Wed, Jan 15, 2025 at 11:10:12PM +0530, Manivannan Sadhasivam wrote:
> > On Mon, Jan 06, 2025 at 09:00:38PM +0530, Anand Moon wrote:
> >
> > Subject should include the word 'fix' not 'improve'
> >
> > > Updates the error message to include the actual return value of
> >
> > s/Updates/Update (imperative form)
> >
> > > devm_clk_bulk_get_all, which provides more context for debugging
> > > and troubleshooting the root cause of clock retrieval failures.
> >
> > Btw, it is not just updating the error message, it also returns the
> > actual error code.
correct.
>
> Already squashed into
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=abdd4c8ea7d7,
> sorry I didn't mention that here.
>
Thanks,

I will focus on improving my communication skills and delivering impactful
commit messages in the future.

Thank
-Anand