Re: [PATCH v3 00/14] x86/virt/tdx: Add SEAMCALL wrappers for KVM

[Edgecombe, Rick P]

On Wed, 2025-01-15 at 11:08 -0500, Paolo Bonzini wrote:
> Hi,
> 
> This is the final-ish version of the "SEAMCALL Wrappers" RFC[0], with
> all the wrappers extracted out of the corresponding TDX patches.
> This version of the series uses u64 only for guest physical addresses
> and error return values:
> 
> * u64 pfn is replaced by struct page
> 
> * u64 level is replaced by int level
> 
> * u64 tdr and u64 tdvpr are replaced by structs that contain struct page
>   for them as well as for tdcs and tdcx.
> 
> A couple functions are also moved over from KVM to tdx.h
> 
> static inline u64 mk_keyed_paddr(u16 hkid, struct page *page)
> static inline int pg_level_to_tdx_sept_level(enum pg_level level)
> 
> The plan is to include these in kvm.git together with their first user.

It looks like you missed these build issues and bugs from v2:
https://lore.kernel.org/kvm/6345272506c5bc707f11b6f54c4bd5015cedcd95.camel@xxxxxxxxx/
https://lore.kernel.org/kvm/3f8fa8fc98b532add1ff14034c0c868cdbeca7f8.camel@xxxxxxxxx/