Re: [PATCH v4 01/11] mtd: core: always create master device
From: Miquel Raynal
Date: Wed Jan 15 2025 - 14:22:38 EST
Hi,
On 14/01/2025 at 14:05:40 GMT, "Usyskin, Alexander" <alexander.usyskin@xxxxxxxxx> wrote:
>> > > Create master device without partition when
>> > > CONFIG_MTD_PARTITIONED_MASTER flag is unset.
>> >
>> > I don't think you took into consideration my remarks regarding the fact
>> > that you would break userspace. If you enable the master, you no longer
>> > have the same device numbering in userspace. I know people should not
>> > care about these numbers, but in practice they do.
>> >
>> > If I'm wrong, please be a little more verbose about why :)
>> >
>> > Thanks,
>> > Miquèl
>>
>> Hi Miquel
>>
>> I've created separate class (mtd_master) for such devices.
>> Uses-space looking for mtd device continues to receive same number of
>> /dev/mtdX devices.
>> There will be additional /dev/mtd_masterX devices, but this is unavoidable, I
>> suppose.
>> Maybe we can rename it to something that not in /dev/mtd* expression (e.g.
>> mastermtdX),
>> if it helps.
>>
>
> Miquel, is this good enough or requires rewrite?
This is an important change that requires attention, and at the time I
have not been able to dedicate enough to this patch.
Also, if the other mtd maintainers want to help, I'll be enthousiastic
about it :)
Thanks,
Miquèl